Bug #279
Fwd: [PATCH] ipv6: nullify ipv6_ac_list and ipv6_fl_list when creating new socket
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | % Done: | 0% |
||
| Category: | Linux Kernel | Spent time: | 8.00 hours | |
| Target version: | 1st Public Cerowrt release | Estimated time: | 8.00 hours |
Description
---------- Forwarded message ----------
From: Yan, Zheng <zheng.z.yan@intel.com>
Date: Sun, Sep 25, 2011 at 5:21 AM
Subject: [PATCH] ipv6: nullify ipv6_ac_list and ipv6_fl_list when
creating new socket
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
ipv6_ac_list and ipv6_fl_list from listening socket are inadvertently
shared with new socket created for connection.
Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
---
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 3c9fa61..79cc646 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c@ -1383,6 +1383,8 @ static struct sock * tcp_v6_syn_recv_sock(struct
sock *sk, struct sk_buff *skb,
newtp->af_specific = &tcp_sock_ipv6_mapped_specific;
#endif
+ newnp->ipv6_ac_list = NULL;
+ newnp->ipv6_fl_list = NULL;
newnp->pktoptions = NULL;
newnp->opt = NULL;
newnp->mcast_oif = inet6_iif(skb);@ -1447,6 +1449,7 @ static struct sock * tcp_v6_syn_recv_sock(struct
sock *sk, struct sk_buff *skb,
First: no IPv4 options.
*/
newinet->inet_opt = NULL;
+ newnp->ipv6_ac_list = NULL;
newnp->ipv6_fl_list = NULL;
/* Clone RX bits */
History
Updated by Dave Täht over 1 year ago
- Category set to Linux Kernel
- Status changed from New to In Progress
- Target version set to Cerowrt-1.0-rc8
- Estimated time set to 8.00
I think this is fixed in 3.1
Updated by Dave Täht over 1 year ago
- Assignee set to Dave Täht
Confirmed fixed in 3.1. How do I account for all the hours I read commits and the mailing lists?
commit 8a04b45367c7943f8f7f30257d42e2106ab7a0bf
Merge: a8062e4 805e969
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue Oct 4 10:37:06 2011 -0700
Merge git://github.com/davem330/net
- git://github.com/davem330/net:
pch_gbe: Fixed the issue on which a network freezes
pch_gbe: Fixed the issue on which PC was frozen when link was downed.
make PACKET_STATISTICS getsockopt report consistently between ring and non-ring
net: xen-netback: correctly restart Tx after a VM restore/migrate
bonding: properly stop queuing work when requested
can bcm: fix incomplete tx_setup fix
RDSRDMA: Fix cleanup of rds_iw_mr_pool
net: Documentation: Fix type of variables
ibmveth: Fix oops on request_irq failure
ipv6: nullify ipv6_ac_list and ipv6_fl_list when creating new socket
cxgb4: Fix EEH on IBM P7IOC
Updated by Dave Täht over 1 year ago
- Status changed from In Progress to Closed
Updated by Dave Täht about 1 year ago
- Target version changed from Cerowrt-1.0-rc8 to 1st Public Cerowrt release