Bug #361
borked ath9k power save
| Status: | New | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | - | Spent time: | - | |
| Target version: | 1st Public Cerowrt release |
Description
---------- Forwarded message ----------
From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Thu, Apr 12, 2012 at 6:32 AM
Subject: Re: [ 00/78] 3.3.2-stable review
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sergio Correia <lists@uece.net>, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, linux-wireless
Mailing List <linux-wireless@vger.kernel.org>, Sujith Manoharan
<c_manoha@qca.qualcomm.com>, "ath9k-devel@lists.ath9k.org"
<ath9k-devel@venema.h4ckr.net>, "John W. Linville"
<linville@tuxdriver.com>
On Thu, Apr 12, 2012 at 4:13 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
On Thu, Apr 12, 2012 at 04:03:59AM +0300, Felipe Contreras wrote:
On Thu, Apr 12, 2012 at 3:29 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
On Wed, Apr 11, 2012 at 07:59:14PM -0400, Sergio Correia wrote:
Hello Greg,
On Wed, Apr 11, 2012 at 7:11 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
This is the start of the stable review cycle for the 3.3.2 release. There are 78 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri Apr 13 23:10:16 UTC 2012. Anything received after that time might be too late.
is there any chance for this one to be included in this review cycle?
I was going to ask for exactly the same thing. My system is completely unusable without this patch; not only does the network doesn't work, but quite often the kernel is stuck consuming 100% of the CPU.
Have you read Documentation/stable_kernel_rules.txt? Based on that, I don't think it can, yet, right?
Why not? This patch makes the code go back to a previous state, it is obviously more stable than the current state, and the code already exists in Linus's tree (in previous releases).
It does? What is the git commit id of the patch? Based in the email above, I assumed it had not made it to Linus's tree already.
It's a revert of c1afdaff90538ef085b756454f12b29575411214, so so just
take a look at the code in c1afdaff90538ef085b756454f12b29575411214^.
But hey, I guess it's OK that 3.3.x is stuck in and endless loop right after booting, because rules are more important than fixing obvious breakage.
What rule did you think I was saying this was not acceptable for?
The fact that the patch as not been applied/reviewed/accepted upstream.
Personally I don't see what is the problem with reverts; we already
know the previous code was working. Sure, in theory it might behave
different due to other changes, but that doesn't seem to be the case
here, plus, it can't be worst than the current situation of staying in
an endless loop.
It appears in 3.4 there are more issues, so the fix there might look
completely different, but regardless, the real issue is that the
proper fix is not yet here.
So the question is do we want 3.3.2 to be completely broken for these
machines, or not?
History
Updated by David Taht about 1 year ago
fixed upstream now
---------- Forwarded message ----------
From: David Miller <davem@davemloft.net>
Date: Thu, Apr 12, 2012 at 9:51 AM
Subject: Re: pull request: wireless 2012-04-12
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
From: "John W. Linville" <linville@tuxdriver.com>
Date: Thu, 12 Apr 2012 10:28:59 -0400
This is a flurry of fixes intended for 3.4...
Many of these are Bluetooth fixes. Gustavo says:
"This is a batch of fixes for 3.4. We have added support to 3 new devices, fixes some NULL-pointer dereferences, memory leaks, memory corruption and endian bugs. There was also a userspace compatibility fix reported by Keith Packard on lkml. The fixes are all simple."
On top of the Bluetooths bits, we have a number of wireless fixes. One is an rt2x00 fix from Chien-Chia Chen which fixes the rfkill registration so that it still works even if the box is booted with the device already blocked. Johannes Berg gives us a pair of fixes, one that corrects a macro parameter when setting a beacon wait timeout, and another that ensures that the proper interface state is used throughout nl80211 so as to avoid warnings and unintended driver behavior. Julia Lawall gives us a fix for a memory leak in an error handling case. Larry Finger is the star performer for this round, giving us a fix for firmware initialization in rtl8192de, a mac80211 fix to quiet some log spam, a fix to avoid a NULL pointer dereference in rtlwifi, an rtlwifi fix to avoid a "sleeping function called from invalid context" BUG, and another rtlwifi fix to avoid "Out of SW-IOMMU space" errors. Paul Gortmaker gives us a fix to avoid bcma build breakage on MIPS. Samuel Ortiz fixes a loop in NFC's LLCP Tx frame fragmentation loop. And finally, Sujith Manoharan reverts an earlier patch in order to fix a regression reported by a number of ath9k users.
Pulled, thanks John.
Updated by Dave Täht about 1 year ago
- Target version set to 1st Public Cerowrt release