Bug #367

Fwd: [PATCH] ipv6: fix rt6_update_expires

Added by David Taht on Apr 17, 2012. Updated on Apr 19, 2012.
Rejected Normal Dave Täht

Description

———- Forwarded message ———-
From: Gao feng gaofeng@cn.fujitsu.com
Date: Tue, Apr 17, 2012 at 7:24 PM
Subject: Re: [PATCH] ipv6: fix rt6_update_expires
To: Jiri Bohac jbohac@suse.cz
Cc: David Miller davem@davemloft.net, netdev@vger.kernel.org

于 2012年04月16日 21:34, Jiri Bohac 写道:
>
> Commit 1716a961 (ipv6: fix problem with expired dst cache) broke PMTU
> discovery. rt6_update_expires() calls dst_set_expires(), which only updates
> dst->expires if it has not been set previously (expires 0) or if the new > expires is earlier than the current dst->expires. > > rt6_update_expires() needs to zero rt->dst.expires, otherwise it will contain > ivalid data left over from rt->dst.from and will confuse dst_set_expires(). > > Signed-off-by: Jiri Bohac <jbohac@suse.cz> > > diff –git a/include/net/ip6_fib.h b/include/net/ip6_fib.h > index ad4126f..68c1f94 100644 > — a/include/net/ip6_fib.h > +++ b/include/net/ip6_fib.h > @@ -143,8 +143,13 @@ static inline void rt6_set_expires(struct rt6_info *rt, unsigned long expires) > >  static inline void rt6_update_expires(struct rt6_info *rt, int timeout) >  { > -     if (!(rt->rt6i_flags & RTF_EXPIRES) && rt->dst.from) > -             dst_release(rt->dst.from); > +     if (!(rt->rt6i_flags & RTF_EXPIRES)) { > +             if (rt->dst.from) > +                     dst_release(rt->dst.from); > +             /* dst_set_expires relies on expires 0
> +                  if it has not been set previously */
> +             rt->dst.expires = 0;
> +     }
>
>       dst_set_expires(&rt->dst, timeout);
>       rt->rt6i_flags |= RTF_EXPIRES;
>

looks good to me, thanks.

History

Updated by Dave Täht on Apr 19, 2012.
this is a 3.4 issue, now fixed. No need to backport.

This is a static export of the original bufferbloat.net issue database. As such, no further commenting is possible; the information is solely here for archival purposes.
RSS feed

Recent News & Articles

Mar 21, 2019 Wiki page
Dave Taht's Take on TCP
Mar 17, 2019 Wiki page
Jake Holland's Stance on ECN
Sep 6, 2018 Wiki page
Pete Heist's Thoughts on ECN
Sep 5, 2018 Wiki page
Dave Taht's Stance on ECN
Sep 4, 2018 Wiki page
Jonathan Morton's Take on ECN

Find us elsewhere

Bufferbloat Mailing Lists
#bufferbloat on Twitter
Google+ group
Archived Bufferbloat pages from the Wayback Machine

Sponsors

Comcast Research Innovation Fund
Nlnet Foundation
Shuttleworth Foundation
GoFundMe

Bufferbloat Related Projects

Congestion Control Blog
Lede Project (OpenWrt)
Flent Network Test Suite
Sqm-Scripts
The Cake shaper
AQMs in BSD
IETF AQM WG

Network Performance Related Resources


Jim Gettys' Blog - The chairman of the Fjord
Toke's Blog - Karlstad University's work on bloat
Voip Users Conference - Weekly Videoconference mostly about voip
Candelatech - A wifi testing company that "gets it".